fix(formatter): Preserve new line if the previous line has an inline comment - #321
Merged
Merged
Conversation
Contributor
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Related issue: #320
What kind of change does this PR introduce?
Fixes an issue where the formatter does not preserve the new line between two statements when the previous statement has an inline comment.
Does this PR introduce a breaking change?
No
New feature or change
What is the current behavior?
The new line between
some_callandanother_callgets deletedWhat is the new behavior?
The new line between the two methods is preserved
Other information
Added tests in
comment_edge_cases.gdbecause it feels like an edge case? But let me know if somewhere else is more appropriate :)All tests pass.
Another (safer?) approach would be to add another branch
instead of removing
&& current_is_declaration, but I don't see any downsides for simplifying the branching logic here.The benchmark also shows no measurable performance impact.